Skip to content

Commit

Permalink
Fix #175 (#176)
Browse files Browse the repository at this point in the history
Reject aborted operations with the "abort reason" instead of AbortError.
  • Loading branch information
nsatragno authored Nov 12, 2021
1 parent 9617033 commit 68a9134
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ spec:css-syntax-3;
: <dfn>signal</dfn>
:: This property lets the developer abort an ongoing {{CredentialsContainer/get()}} operation.
An aborted operation may complete normally (generally if the abort was received after the
operation finished) or reject with an "{{AbortError}}" {{DOMException}}."
operation finished) or reject with an [=AbortSignal/abort reason=].
</div>

<div class="note">
Expand Down Expand Up @@ -755,7 +755,7 @@ spec:css-syntax-3;
: <dfn>signal</dfn>
:: This property lets the developer abort an ongoing {{CredentialsContainer/create()}}
operation. An aborted operation may complete normally (generally if the abort was received
after the operation finished) or reject with an "{{AbortError}}" {{DOMException}}."
after the operation finished) or reject with an [=AbortSignal/abort reason=].
</div>

## Algorithms ## {#algorithms}
Expand All @@ -771,8 +771,9 @@ spec:css-syntax-3;

2. Assert: |settings| is a [=secure context=].

3. If <code>|options|.{{CredentialRequestOptions/signal}}</code>'s [=AbortSignal/aborted flag=]
is set, then return [=a promise rejected with=] an "{{AbortError}}" {{DOMException}}.
3. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
then return [=a promise rejected with=]
<code>|options|.{{CredentialRequestOptions/signal}}</code>'s [=AbortSignal/abort reason=].

4. Let |p| be [=a new promise=].

Expand Down Expand Up @@ -918,8 +919,9 @@ spec:css-syntax-3;
types in order to support a "sign-up" use case. For the moment, though, we're punting
on that by restricting the dictionary to a single entry.

7. If <code>|options|.{{CredentialCreationOptions/signal}}</code>'s [=AbortSignal/aborted
flag=] is set, then return [=a promise rejected with=] an "{{AbortError}}" {{DOMException}}.
3. If <code>|options|.{{CredentialRequestOptions/signal}}</code> is [=AbortSignal/aborted=],
then return [=a promise rejected with=]
<code>|options|.{{CredentialRequestOptions/signal}}</code>'s [=AbortSignal/abort reason=].

8. Let |p| be [=a new promise=].

Expand Down

0 comments on commit 68a9134

Please sign in to comment.