Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove noexport for same-origin with ancestors #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove noexport for same-origin with ancestors #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ spec:css-syntax-3;
<!-- NOTE: '<h4>' maps to the same heading level as three hashs '###', thus using '<h5>' for the next section -->
<h5 id="algorithm-same-origin-with-ancestors" algorithm>Same-Origin with its Ancestors</h5>

An [=environment settings object=] (|settings|) is <dfn noexport>same-origin with its
An [=environment settings object=] (|settings|) is <dfn>same-origin with its
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Should we scope this definition to environment settings object with a <dfn for="">?

Copy link
Member

@marcoscaceres marcoscaceres Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I agree this should be scoped because it's explicitly comparing environment settings objects.

Also, I wonder if we should actually move this to HTML as it seems generally useful (and they own the definition of environment settings object)? cc @domenic

Copy link

@domenic domenic Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to not work for all environment settings objects, as it only works for Window environment settings objects.

We could move this to HTML, which already does similar things in e.g. https://html.spec.whatwg.org/#coop-reporting:inclusive-ancestor-navigables . However we would not apply it to generic environment settings objects (which have a fraught notion of ancestry, given the existence of shared and nested workers). We would apply it to Document objects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that seems better... we might need to actually check if Cred Man is even using these things correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Thanks for chiming in Domenic!

ancestors</dfn> if the following algorithm returns `true`:

<ol class="algorithm">
Expand Down
Loading