Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[preventSilentAccess]] seems incorrect #1956

Closed
emlun opened this issue Aug 31, 2023 · 2 comments
Closed

[[preventSilentAccess]] seems incorrect #1956

emlun opened this issue Aug 31, 2023 · 2 comments

Comments

@emlun
Copy link
Member

emlun commented Aug 31, 2023

The section §5.1.6. Preventing Silent Access to an Existing Credential - PublicKeyCredential’s [[preventSilentAccess]](credential, sameOriginWithAncestors) Method describes preventSilentAccess as an internal method of Credential, but it is in fact a public method of CredentialsContainer. As such, I don't think this belongs as a subsection of §5.1. PublicKeyCredential Interface, because there is no preventSilentAccess() method in the interface - it's on the navigator.credentials object.

The section was added in PR #758, in response to issue #565. I think it does makes sense to keep the mention that the method has no effect on WebAuthn credentials. Maybe we could move that to the end of §5.1. PublicKeyCredential Interface, where we describe some other relations to the Credential supertype?

§5.1. PublicKeyCredential Interface
[...]
PublicKeyCredential's interface object inherits Credential's implementation of [[CollectFromCredentialStore]](origin, options, sameOriginWithAncestors), and defines its own implementation of [[Create]](origin, options, sameOriginWithAncestors), [[DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors), and [[Store]](credential, sameOriginWithAncestors).

@emlun emlun self-assigned this Aug 31, 2023
@emlun
Copy link
Member Author

emlun commented Aug 31, 2023

@selfissued Any thoughts on this?

@emlun
Copy link
Member Author

emlun commented Jan 10, 2024

Fixed by #1991.

@emlun emlun closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant