Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in reference to variable |effectiveDomain| #2182

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

emlun
Copy link
Member

@emlun emlun commented Oct 7, 2024

Fixes this Bikeshed lint:

LINE ~3100: The var 'effective domain' (in global scope) is only used once.
If this is not a typo, please add an ignore='' attribute to the <var>.

Preview | Diff

Fixes this Bikeshed lint:

```
LINE ~3100: The var 'effective domain' (in global scope) is only used once.
If this is not a typo, please add an ignore='' attribute to the <var>.
```
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh

@selfissued selfissued merged commit 1fcb5c2 into main Oct 9, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Oct 9, 2024
SHA: 1fcb5c2
Reason: push, by selfissued

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@emlun emlun deleted the lint-var-effective-domain branch October 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants