Fix reference for element disabled #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
approved these changes
Nov 20, 2023
whimboo
force-pushed
the
element-disabled
branch
from
2cb5e2f
to
5e44158
Compare
whimboo
requested review from
shs96c,
AutomatedTester,
gsnedders and
sadym-chromium
|
@sadym-chromium, @gsnedders, @AutomatedTester, @shs96c could you please review this change? While browsers may still use the Thanks. |
I would appreciate feedback for this change from those listed above. Are you ok with this change or do you have objections? Thanks. |
sadym-chromium
approved these changes
Dec 14, 2023
shs96c
approved these changes
Dec 15, 2023
|
Thank you all for the reviews. I think that we basically have enough reviews from different stake holders that we can get the PR merged. |
github-actions bot
added a commit
that referenced
this pull request
Dec 15, 2023
SHA: 2e6ca25 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Dec 15, 2023
SHA: 2e6ca25 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
Dec 16, 2023
SHA: 2e6ca25 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly check an element for
disabledwe have to reference theactually disabledsection of the HTML spec.It means the link changes from https://html.spec.whatwg.org/#concept-fe-disabled to https://html.spec.whatwg.org/#concept-element-disabled.
@jgraham can you please review?
Preview | Diff