-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: about:
matching
#755
Comments
This comment has been minimized.
This comment has been minimized.
Safari supports |
Indeed it appears to have been resolved since I first noticed this in 2021 (Safari 14.0.1) fregante/webext-permission-toggle#14 So it's just a Chrome issue |
I think that allowing explicit
So the array of strings as you wrote it sounds good to me. Dropping |
That is also what I meant (as per Proposal). I will update the topic to make it clearer. |
It would be helpful to get some more concrete use cases where matching Between the original issue description, #756, and fregante/webext-permission-toggle#14 I gather that one of the problems that you're looking to solve is that you don't want to show context menus on pages in situations where the extension cannot provide its features. @erosman, can you provide more context on the scenario you described where you wanted to provide a context menu on 'about:newtab' and 'about:blank', but not |
Exactly ...
FoxyProxy has a Tab Proxy feature which similar to Firefox containers, relates to a tab and is tied to its ID. For the purpose of proxying, it is impractical to have the menu on See also: |
I agree |
Proposal:
about:
matchingBackground
Match patterns does not match
about:
URLs.While some APIs such as Content scripts or scripting support
about:
matching via additional options (match_about_blank
,match_origin_as_fallback
), there are others that don't have such options.menus/contextMenus is a commonly used example where
documentUrlPatterns
is insufficient for this purpose.I recently needed to limit the context-menu to
['http://*/*', 'https://*/*','about:newtab', 'about:blank']
. The only option is to omitdocumentUrlPatterns
which results in the contextMenu appearing in many unwanted pages such asfile://
, toolbar popups, and extension pages.Proposal
Provide a method to match
about:newtab
,about:blank
, etcSuggestions
A few possibilities:
about:newtab
,about:blank
and in Match patterns (preferable)scripting
) to APIs that don't have itThe text was updated successfully, but these errors were encountered: