Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document How we work #291

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Document How we work #291

merged 1 commit into from
Nov 10, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Oct 13, 2022

Fixes #29.

@oliverdunk
Copy link
Member

oliverdunk commented Oct 13, 2022 •
edited
Loading

Such a big improvement 🙌

Should we add a link to this in the README or even considering moving some of it there? I think a lot of this is key information that it would be nice to make as visible as possible.

@Rob--W
Copy link
Member Author

Rob--W commented Oct 17, 2022

Such a big improvement 🙌

Should we add a link to this in the README or even considering moving some of it there? I think a lot of this is key information that it would be nice to make as visible as possible.

What is the "link to his"? I've already put a link to CONTRIBUTING.md in the README.

@oliverdunk
Copy link
Member

Such a big improvement 🙌
Should we add a link to this in the README or even considering moving some of it there? I think a lot of this is key information that it would be nice to make as visible as possible.

What is the "link to his"? I've already put a link to CONTRIBUTING.md in the README.

I think I totally missed that the first time, sorry. I do think it'd be nice to just pull some of this information in to the README directly but definitely not a blocker for this PR.

This was referenced Oct 26, 2022
Closed
Closed
dotproto
dotproto approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@dotproto dotproto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @Rob--W!

@Rob--W Rob--W merged commit 70a05e5 into main Nov 10, 2022
@Rob--W Rob--W deleted the contrib-guide-2022 branch November 10, 2022 18:02
github-actions bot added a commit that referenced this pull request Nov 10, 2022
@Rob--W @github-actions
Merge pull request #291 from w3c/contrib-guide-2022
c78dc9c 
SHA: 70a05e5
Reason: push, by Rob--W

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Rob--W Rob--W mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotproto dotproto dotproto approved these changes

@xeenon xeenon xeenon approved these changes

@mukul-p mukul-p Awaiting requested review from mukul-p

@zombie zombie Awaiting requested review from zombie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update contributing guide with info on current communication channels
4 participants
@Rob--W @oliverdunk @xeenon @dotproto