-
Notifications
You must be signed in to change notification settings - Fork 32
0x0B and 0x0C stripped from header values #111
Comments
In some python standard library thing, I'm afraid :/ |
Yeah it's not trivial to change, but maybe we want to move away from using the stdlib parts here in general, especially if we want to allow early responses and so on. Is this affecting a test that you're writing right now? |
Yes, this affects web-platform-tests/wpt#4525. |
Yeah, I'm increasingly in favour of moving away from it as well. We could possibly refactor stuff once we're away from that too… |
What standard library are we using now? It seems we should file a bug there too if they strip 0x0B and 0x0C (if they use GitHub...). |
@annevk unless you can make it out to be a security issue, it's almost certainly not getting fixed in Python 2. |
(It seems to already have been fixed in Python 3.) |
https://bugs.python.org/issue22233 was the issue. It's a little strange they don't consider the CR LF sequence a single newline though. I wonder if that leads to issues. Anyway, moving to Python 3 is not an option so I guess we'll have to fix this here. |
Nah, that bug was only introduced in Python 3, but yes, would've broken this too! python/cpython@15a312f is where the bug that breaks this in 2.7 was fixed in Python 3. |
See whatwg/fetch#332 for context. Once w3c/wptserve#111 is fixed these tests can be further updated.
This issue has been moved to web-platform-tests/wpt#8372; please continue all discussion there. |
These are not HTTP whitespace. They should be preserved I think. Where is the header value parsing code?
The text was updated successfully, but these errors were encountered: