Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

0x0B and 0x0C stripped from header values #111

Closed
annevk opened this issue Jan 11, 2017 · 10 comments
Closed

0x0B and 0x0C stripped from header values #111

annevk opened this issue Jan 11, 2017 · 10 comments

Comments

@annevk
Copy link
Member

annevk commented Jan 11, 2017

These are not HTTP whitespace. They should be preserved I think. Where is the header value parsing code?

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 11, 2017

In some python standard library thing, I'm afraid :/

@jgraham
Copy link
Member

jgraham commented Jan 11, 2017

Yeah it's not trivial to change, but maybe we want to move away from using the stdlib parts here in general, especially if we want to allow early responses and so on.

Is this affecting a test that you're writing right now?

@annevk
Copy link
Member Author

annevk commented Jan 11, 2017

Yes, this affects web-platform-tests/wpt#4525.

@gsnedders
Copy link
Member

Yeah, I'm increasingly in favour of moving away from it as well. We could possibly refactor stuff once we're away from that too…

@annevk
Copy link
Member Author

annevk commented Jan 11, 2017

What standard library are we using now? It seems we should file a bug there too if they strip 0x0B and 0x0C (if they use GitHub...).

@gsnedders
Copy link
Member

@annevk unless you can make it out to be a security issue, it's almost certainly not getting fixed in Python 2.

@gsnedders
Copy link
Member

(It seems to already have been fixed in Python 3.)

@annevk
Copy link
Member Author

annevk commented Jan 12, 2017

https://bugs.python.org/issue22233 was the issue. It's a little strange they don't consider the CR LF sequence a single newline though. I wonder if that leads to issues. Anyway, moving to Python 3 is not an option so I guess we'll have to fix this here.

@gsnedders
Copy link
Member

Nah, that bug was only introduced in Python 3, but yes, would've broken this too!

python/cpython@15a312f is where the bug that breaks this in 2.7 was fixed in Python 3.

annevk added a commit to web-platform-tests/wpt that referenced this issue Jan 17, 2017
See whatwg/fetch#332 for context.

Once w3c/wptserve#111 is fixed these tests can be further updated.
@wpt-issue-mover
Copy link
Collaborator

This issue has been moved to web-platform-tests/wpt#8372; please continue all discussion there.

@w3c w3c locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants