allow any type of cover #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TzviyaSiegman
approved these changes
Jul 23, 2018
iherman
approved these changes
Jul 24, 2018
|
One thing, maybe: we did say at the call that we include the more "permissive" version in the draft but asking the community to comment on this issue because there was no 100% consensus. Maybe a reference to an issue and an editorial note on this would be good. |
…on what cover can be
|
I've added a reference to issue 261 since it already contains the discussion to date, so we should leave it open after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest comment from @TzviyaSiegman in #261, here's a rewrite of the cover section to allow any type of resource. I included a "must" that when there are multiple covers specified they be unique on at least one property. I also added "should" for title and description, and expanded the examples.
I removed any mention of creating a cover or how to use it, as it's not clear what the user agent would create or when. Given the open-ended nature, this will have to be covered in any sections that make use of the cover, or left to user agents to provide on their own.
Comments welcome if I missed anything from today's discussion.
Preview | Diff