stats: support scoring of single item vectors #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianFranzen
force-pushed
the
patches/nan_stats
branch
from
8862553
to
9fc9aa0
Compare
|
Rebased on stagging. |
ironoa
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
stdimplementation only works for arrays that have at least two elements, as with just one element it ends up dividing by zero. This then initializes allstandardDeviationtoNaNand as a result ends up breaking the scoring with following trace:{ "errors": { "bondedStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "bondedStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"bondedStats.standardDeviation\"" }, "faultsStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "faultsStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"faultsStats.standardDeviation\"" }, "inclusionStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "inclusionStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"inclusionStats.standardDeviation\"" }, "spanInclusionStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "spanInclusionStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"spanInclusionStats.standardDeviation\"" }, "discoveredAtStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "discoveredAtStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"discoveredAtStats.standardDeviation\"" }, "nominatedAtStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "nominatedAtStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"nominatedAtStats.standardDeviation\"" }, "offlineStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "offlineStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"offlineStats.standardDeviation\"" }, "rankStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "rankStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"rankStats.standardDeviation\"" }, "locationStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "locationStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"locationStats.standardDeviation\"" }, "regionStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "regionStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"regionStats.standardDeviation\"" }, "countryStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "countryStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"countryStats.standardDeviation\"" }, "providerStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "providerStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"providerStats.standardDeviation\"" }, "nominatorStakeStats.standardDeviation": { "stringValue": "\"NaN\"", "valueType": "number", "kind": "Number", "value": null, "path": "nominatorStakeStats.standardDeviation", "reason": { "generatedMessage": true, "code": "ERR_ASSERTION", "actual": false, "expected": true, "operator": "==" }, "name": "CastError", "message": "Cast to Number failed for value \"NaN\" (type number) at path \"nominatorStakeStats.standardDeviation\"" } }, "_message": "ValidatorScoreMetadata validation failed", "name": "ValidationError", "message": "ValidatorScoreMetadata validation failed: bondedStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"bondedStats.standardDeviation\", faultsStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"faultsStats.standardDeviation\", inclusionStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"inclusionStats.standardDeviation\", spanInclusionStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"spanInclusionStats.standardDeviation\", discoveredAtStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"discoveredAtStats.standardDeviation\", nominatedAtStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"nominatedAtStats.standardDeviation\", offlineStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"offlineStats.standardDeviation\", rankStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"rankStats.standardDeviation\", locationStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"locationStats.standardDeviation\", regionStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"regionStats.standardDeviation\", countryStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"countryStats.standardDeviation\", providerStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"providerStats.standardDeviation\", nominatorStakeStats.standardDeviation: Cast to Number failed for value \"NaN\" (type number) at path \"nominatorStakeStats.standardDeviation\"" }