ApiHandler / ChainData refactoring #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutantcornholio
force-pushed
the
yuri/websocket-disconnect
branch
2 times, most recently
from
761966e
to
bc312a9
Compare
ironoa
reviewed
May 29, 2024
|
|
||
| const chainType = await chaindata?.api?.rpc.system.chain(); | ||
| const chainType = await api.rpc.system.chain(); | ||
| if (!chainType) { | ||
| return null; | ||
| } | ||
| const denom = | ||
| chainType.toString() == "Polkadot" ? 10000000000 : 1000000000000; |
There was a problem hiding this comment.
could this be fetched dynamically from the api ?
There was a problem hiding this comment.
api.registry.getChainProperties() should return tokenDecimals, where denom = 10 ** tokenDecimals
| @@ -200,8 +197,9 @@ export default class Nominator extends EventEmitter { | |||
|
|
|||
| public async stash(): Promise<string> { | |||
| try { | |||
| const api = this.handler.getApi(); | |||
| const ledger = await api?.query.staking.ledger(this.bondedAddress); | |||
| // TODO: chain interaction should be performed exclusively in ChainData | |||
There was a problem hiding this comment.
what about this series of TODOs ?
There was a problem hiding this comment.
It's better to tackle it separately: https://github.com/w3f/1k-validators-be-PRIVATE/issues/85
This changeset has already gotten too big
Removed a lot of retry/reconnect logic from ApiHandler and ChainData, as it was spawning a lot of PJS instances, which also handling reconnects on its own. This change also properly adpots the idea of talking both to relay chain and to parachains, depending on queried data. With new logic, each ApiHandler instance governs an interface to a single chain, where it can switch endpoints and do reconnects on its own. `ApiHandler.getApi()` returns a PJS instance that should work, and will block in case we're reconnecting. PeopleApi endpoints now live in configs, instead of being hardcoded. Instead of passing around ApiHandlers, passing a ChainData instance now, as it contains both ApiHandlers instance now, and as it is an intended abstraction for it
mutantcornholio
force-pushed
the
yuri/websocket-disconnect
branch
from
bc312a9
to
5ad0ab4
Compare
apiPeopleEndpoints in kusama configs
mutantcornholio
force-pushed
the
yuri/websocket-disconnect
branch
from
ca8fb57
to
8c2ae30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a lot of retry/reconnect logic from ApiHandler and ChainData, as it was spawning a lot of PJS instances, which also handling reconnects on its own.
This change also properly adpots the idea of talking both to relay chain and to parachains, depending on queried data.
With new logic, each ApiHandler instance governs an interface to a single chain, where it can switch endpoints and do reconnects on its own.
ApiHandler.getApi()returns a PJS instance that should work, and will block in case we're reconnecting.PeopleApi endpoints now live in configs, instead of being hardcoded.
Instead of passing around ApiHandlers, passing a ChainData instance now, as it contains both ApiHandlers instance now, and as it is an intended abstraction for it
Fixes https://github.com/w3f/1k-validators-be-PRIVATE/issues/14