Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stary Network #233

Merged
merged 12 commits into from
Feb 11, 2021
Merged

Stary Network #233

merged 12 commits into from
Feb 11, 2021

Conversation

poria-cat
Copy link
Contributor

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC or Ethereum address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below USD $30k for initial grant applications and $100k for follow-up grants at the time of submission.
  • The initial PR contains only one commit (squash if needed before submitting your PR).
  • The grant will only be announced once we successfully delivered the first milestone.

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. But why wouldn’t you use ERC721 for these use-cases? Are there similar initiatives in the ethereum ecosystem that show that there is actually the need for a third nft standard.

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Feb 2, 2021
@Noc2 Noc2 self-assigned this Feb 2, 2021
@poria-cat
Copy link
Contributor Author

poria-cat commented Feb 2, 2021

Hi @Noc2 , thanks for the feedback. SubNFT is also using ERC721, it just needs some additional indexes to associate subNFT with NFT, so this is more like a special application of ERC721.
In the Ethernet ecosystem,NIFTEX can create and trade ERC20 fractions of NFTs. Starry can also convert NFT to fungible tokens , which can bring more liquidity.
Here is the updated protocol.

@poria-cat poria-cat requested a review from Noc2 February 5, 2021 02:34
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Now, I have understood the concept and the reason behind it. Could you potentially integrate some contribution to the PSP process process as part of the grant. Is there potentially already an Ethereum Improvement Proposals that addresses this issue?

@Noc2
Copy link
Collaborator

Noc2 commented Feb 5, 2021

Btw. there is a new Element/Telegram chat group for all things NFT on Kusama and Polkadot.

@rrtti
Copy link

rrtti commented Feb 5, 2021

@poria-cat Hi! A group of devs, PMs and designers, along with artists and NFT creators are working on a NFT strategy for Kusama network (already ongoing: https://kusama.polkassembly.io/post/303). The effort includes the development of Asset creator platforms (RMRK.app and PolkadotAssetJS - funded by treasury) and the development and maintenance of two pallets to be natively deployed on Kusama: ORML NFT pallet and a PoC NFT Gallery to work as a first experimentation in the direction of a native application. 

We would love to discuss your project to see how it could align with our efforts on this: let me know what you think!

@usetech-llc
Copy link

Most of these things are implemented already, we have 3 (or more) NFT pallets, refungibility (ERC1155) is also implemented and live on Unique. Ecosystem would benefit more from more downstream efforts to actually get that infrastructure to end users. More NFT wallets, minting solutions, advanced formats (like interactive NFTs), NFT relationships, advanced ownership structures, alternative economic models, etc., as well as real dapps - games, for example.

@poria-cat
Copy link
Contributor Author

poria-cat commented Feb 5, 2021

Thanks for the update. Now, I have understood the concept and the reason behind it. Could you potentially integrate some contribution to the PSP process process as part of the grant. Is there potentially already an Ethereum Improvement Proposals that addresses this issue?

Glad to be able to contribute to the PSP process. There is no relevant proposal on the Ethernet, the protocol content will be updated later. In the new version, Pallet_NFT has been removed, and Pallet_NFTDAO has been added.

@poria-cat
Copy link
Contributor Author

@poria-cat Hi! A group of devs, PMs and designers, along with artists and NFT creators are working on a NFT strategy for Kusama network (already ongoing: https://kusama.polkassembly.io/post/303). The effort includes the development of Asset creator platforms (RMRK.app and PolkadotAssetJS - funded by treasury) and the development and maintenance of two pallets to be natively deployed on Kusama: ORML NFT pallet and a PoC NFT Gallery to work as a first experimentation in the direction of a native application. 

We would love to discuss your project to see how it could align with our efforts on this: let me know what you think!

Hi, it's great to discuss the project together and contribute to the Polkadot's NFT ecosystem.

@poria-cat
Copy link
Contributor Author

Most of these things are implemented already, we have 3 (or more) NFT pallets, refungibility (ERC1155) is also implemented and live on Unique. Ecosystem would benefit more from more downstream efforts to actually get that infrastructure to end users. More NFT wallets, minting solutions, advanced formats (like interactive NFTs), NFT relationships, advanced ownership structures, alternative economic models, etc., as well as real dapps - games, for example.

Hi, thanks for the suggestion, Unique is an amazing project, Starry's focus is on providing better mobility for NFT, I will make an update on the protocol later

@Noc2
Copy link
Collaborator

Noc2 commented Feb 5, 2021

Most of these things are implemented already, we have 3 (or more) NFT pallets, refungibility (ERC1155) is also implemented and live on Unique. Ecosystem would benefit more from more downstream efforts to actually get that infrastructure to end users. More NFT wallets, minting solutions, advanced formats (like interactive NFTs), NFT relationships, advanced ownership structures, alternative economic models, etc., as well as real dapps - games, for example.

Where can I find the open source code (for example ERC1155)?

@poria-cat poria-cat requested a review from Noc2 February 5, 2021 12:17
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, just to follow up on the above: Is there potentially already an Ethereum Improvement Proposals that addresses this issue? What do you mean with managing the NFTs in a DAO way? Do you already have a concrete idea how you are going to implement this? Also would it be possible to reduce the price a little bit further?

@poria-cat
Copy link
Contributor Author

poria-cat commented Feb 9, 2021

Thanks for the reply @Noc2. I have made some updates.

is there potentially already an Ethereum Improvement Proposals that addresses this issue?

Maybe it's eip-998

What do you mean with managing the NFTs in a DAO way? Do you already have a concrete idea how you are going to implement this

Added an architecture image about nft dao for understanding

Also would it be possible to reduce the price a little bit further?

Sure, Reduced from 14,000 dai to 12,000 dai

@poria-cat poria-cat requested a review from Noc2 February 9, 2021 09:48
Noc2
Noc2 previously approved these changes Feb 10, 2021
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I also started to look a little bit into it. As pointed out here it might not make sense to actually come up with an additional token standard for it. But there is also the Re-Fungible Token under development. So overall, I’m happy to go ahead with it and feel free to ping me once you start the discussion about a PSP. I will share the application with the rest of the team.

@Noc2 Noc2 removed the changes requested The team needs to clarify a few things first. label Feb 10, 2021
@Noc2 Noc2 added the ready for review The project is ready to be reviewed by the committee members. label Feb 10, 2021
@poria-cat
Copy link
Contributor Author

As pointed out here it might not make sense to actually come up with an additional token standard for it. But there is also the Re-Fungible Token under development.

Wow, these great references will give me more inspiration in future development.

So overall, I’m happy to go ahead with it and feel free to ping me once you start the discussion about a PSP. I will share the application with the rest of the team.

Okay, I will. Thank you for all your work on this. @Noc2

@mmagician
Copy link
Contributor

@poria-cat That's indeed a novel proposal & I would like to support it, but in my opinion 12,000 DAI is overly excessive for the amount of work that the project entails.

Furthermore, thanks for adding the diagram for illustrating the operations of the NFTDAO submodule, but perhaps you could describe the details a bit more, or provide a couple of user stories to illustrate how the functionality of token management works from the different users' perspectives?

Lastly, some of your demo links are unaccessible.

@poria-cat
Copy link
Contributor Author

poria-cat commented Feb 11, 2021

Hi @mmagician , thanks for your review.

but in my opinion 12,000 DAI is overly excessive for the amount of work that the project entails

Okay, reduced from 12,000 DAI to 10,000 DAI. This is not an easy task because of the addition of NFT DAO.

or provide a couple of user stories to illustrate how the functionality of token management works from the different users' perspectives?

Thanks for your advice, this was added to Additional Information

Lastly, some of your demo links are unaccessible.

whoops, I forgot this was a page created using CRA and have solved the problem using hash router

@poria-cat poria-cat requested a review from Noc2 February 11, 2021 10:29
Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, that makes a bit more sense now with the DAO, though I'm not sure about the extent to which people will use it - let's try and see. Thanks for the update, I'll be happy to support the project!

@poria-cat
Copy link
Contributor Author

Thanks for your support and let's look forward to the future together! @mmagician

@mmagician mmagician merged commit ecc0d0f into w3f:master Feb 11, 2021
@github-actions
Copy link
Contributor

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully delivered their first milestone. Please observe the foundation’s guidelines when making any announcements; in particular, don’t announce the grant publicly before you've completed at least the first milestone of the project.

At that point, we will be happy to collaborate on an announcement about the work you’re doing. Please get in touch with us at grantspr@web3.foundation in case you're interested (at least two weeks notice is preferred).

@mmagician
Copy link
Contributor

@poria-cat The ethereum payment address provided in your invoice and the address in your application don't match.
Please either:

  1. Submit a new invoice with the same address as in the application.
  2. Submit a PR to the original application to change your payout address.

@RouvenP
Copy link
Contributor

RouvenP commented Jun 28, 2021

hi @poria-cat we transferred the payment for milestone 1.

@poria-cat
Copy link
Contributor Author

poria-cat commented Jun 28, 2021

hi @poria-cat we transferred the payment for milestone 1.

@RouvenP Sounds great, but I didn't get some Dai. 😭

@RouvenP
Copy link
Contributor

RouvenP commented Jun 28, 2021

@poria-cat you're right, apologies - we sent it now :)

@poria-cat
Copy link
Contributor Author

Thanks @RouvenP, now I get it, lol. Thanks @Noc2 and @mmagician for all your help during this time!
Thanks to Web3 Foundation for giving me time to realize my idea, I hope Starry's batch minting, fragmented NFT and moloch-based DAO that can use NFT as a tribute will help more people!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants