Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- match definition of parity function to sgn0 of ietf draft in swu map #33

Merged
merged 3 commits into from
Jan 13, 2022
Merged

- match definition of parity function to sgn0 of ietf draft in swu map #33

merged 3 commits into from
Jan 13, 2022

Conversation

drskalman
Copy link
Collaborator

@drskalman drskalman commented Jan 12, 2022 •
edited
Loading

  • adapt unit tests to the new definition

Description

closes: arkworks-rs#343 (comment)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@drskalman drskalman self-assigned this Jan 12, 2022
@drskalman drskalman mentioned this pull request Jan 12, 2022
Merged
6 tasks
InaOana
InaOana reviewed Jan 12, 2022
View reviewed changes
Copy link

@InaOana InaOana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, code and tests match the sig0 ieft draft.

mmagician
mmagician requested changes Jan 12, 2022
View reviewed changes
ec/src/hashing/curve_maps/swu/mod.rs Outdated Show resolved Hide resolved
ec/src/hashing/curve_maps/swu/mod.rs Outdated Show resolved Hide resolved
ec/src/hashing/curve_maps/swu/mod.rs Outdated Show resolved Hide resolved
@drskalman
non-zero not none-zero
dc9210f 
Co-authored-by: Marcin <marcin@web3.foundation>
@drskalman drskalman requested a review from mmagician January 12, 2022 18:38
@mmagician mmagician merged commit bcc53f5 into hash_to_curve_wb Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InaOana InaOana InaOana left review comments

@mmagician mmagician mmagician approved these changes

@Pratyush Pratyush Pratyush approved these changes

Assignees

@drskalman drskalman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drskalman @Pratyush @mmagician @InaOana