Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to "maintain-guides-async-backing.md" #5506

Merged

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Jan 12, 2024

Addresses some issues found in paritytech/polkadot-sdk#2826.

Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DrW3RK DrW3RK merged commit af3e633 into w3f:master Jan 12, 2024
2 checks passed
@evilrobot-01
Copy link
Contributor

evilrobot-01 commented Jan 17, 2024

Seems that this PR broke the screenshot image for implementing the AuraUnincludedSegmentApi within a runtime (see Phase 1, Step 7, substep 3 at https://wiki.polkadot.network/docs/maintain-guides-async-backing#phase-1---update-parachain-runtime) due to using the wrong image name.

The replaced image aligned with the config at https://github.com/paritytech/polkadot-sdk/blob/c01dbebeaa6394691974de46dd2d41a582f6a4c2/cumulus/parachains/runtimes/testing/rococo-parachain/src/lib.rs#L839

Edit: note also that the mention of async backing already being part of the cumulus parachain template is incorrect. The link points to a branch on the old cumulus repo and the cumulus template within the Polkadot SDK repo does not yet seem to be async backing ready.

@mrcnski
Copy link
Contributor Author

mrcnski commented Jan 17, 2024

You're right, should have created a new image called async-backing-unincluded-segment-capacity.png. Sorry, I missed that the same path was used in two places. Will fix it soon.

Edit: note also that the mention of async backing already being part of the cumulus parachain template is incorrect.

Where is this mention? Let me know what and how to fix and I'll include it in the follow-up PR.

@evilrobot-01
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants