Fixed code smell

w3stling · Aug 10, 2023 · 9ad6fb4 · 9ad6fb4
1 parent ddb5daf
commit 9ad6fb4
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/com/apptasticsoftware/rssreader/AbstractRssReader.java b/src/main/java/com/apptasticsoftware/rssreader/AbstractRssReader.java
@@ -458,7 +458,7 @@ else if (firstChar == 13 || Character.isWhitespace(firstChar)) {
     class RssItemIterator implements Iterator<I> {
         private final StringBuilder textBuilder;
         private final InputStream is;
-        private final Stack<String> elementStack;
+        private final Deque<String> elementStack;
         private XMLStreamReader reader;
         private C channel;
         private I item = null;
@@ -471,7 +471,7 @@ public RssItemIterator(InputStream is) {
             this.is = is;
             nextItem = null;
             textBuilder = new StringBuilder();
-            elementStack = new Stack<>();
+            elementStack = new ArrayDeque<>();
 
             try {
                 var xmlInFact = XMLInputFactory.newInstance();
@@ -564,7 +564,7 @@ void parseStartElement() {
             elementName = reader.getLocalName();
             var prefix = reader.getPrefix();
             var nsLocalName = toNsName(prefix, elementName);
-            elementStack.push(nsLocalName);
+            elementStack.addLast(nsLocalName);
 
             if ("channel".equals(nsLocalName) || "feed".equals(nsLocalName)) {
                 channel = createChannel();
@@ -625,7 +625,7 @@ boolean parseEndElement() {
             var nsLocalName = toNsName(prefix, localName);
             var text = textBuilder.toString().trim();
             var elementFullPath = getElementFullPath();
-            elementStack.pop();
+            elementStack.removeLast();
 
             if (isChannelPart)
                 parseChannelCharacters(channel, prefix, elementName, elementFullPath, text);