Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add discriminator train #4

Merged
merged 1 commit into from
Mar 31, 2024
Merged

add discriminator train #4

merged 1 commit into from
Mar 31, 2024

Conversation

ZIMUQIN-L
Copy link
Collaborator

add discriminator train;
Also a little doubt about the generator train

@ZIMUQIN-L
Copy link
Collaborator Author

Also the input of the discriminator should be two images, I forgot to change it for the generator part xx

@@ -146,6 +146,9 @@
pred_fake = discriminator(imgs_fake.detach())
# calculate loss function
loss_1 = L1_G(imgs_fake, imgs_good_gt)
# for the loss_cgan, since the size of pred_fake(result of discriminator)
# is not the same as `img_size`(origin size), maybe we can use
# loss_cgan = L_BCE(pred_fake, torch.ones_like(pred_fake))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll fix it.

@w4a2y4 w4a2y4 merged commit 3d7367e into sea-pix-gan Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants