fix: ignore unexpected values in localStorage (#146)

wKovacs64 · Feb 13, 2023 · a6b609d · a6b609d
1 parent ca740c1
commit a6b609d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/.changeset/neat-colts-impress.md b/.changeset/neat-colts-impress.md
@@ -0,0 +1,5 @@
+---
+'gatsby-plugin-use-dark-mode': patch
+---
+
+Ignore unexpected values in localStorage.
diff --git a/src/gatsby-node.ts b/src/gatsby-node.ts
@@ -86,19 +86,16 @@ function generateNoFlashScript({
       var preferDarkQuery = '(prefers-color-scheme: dark)';
       var mql = window.matchMedia(preferDarkQuery);
       var supportsColorSchemeQuery = mql.media === preferDarkQuery;
-      var localStorageTheme = null;
+      var localStorageValue = null;
       try {
-        localStorageTheme = localStorage.getItem(storageKey);
+        localStorageValue = JSON.parse(localStorage.getItem(storageKey));
       } catch (err) {}
-      var localStorageExists = localStorageTheme !== null;
-      if (localStorageExists) {
-        localStorageTheme = JSON.parse(localStorageTheme);
-      }
+      var isLocalStorageValueValid = localStorageValue === true || localStorageValue === false;
 
       // Determine the source of truth
-      if (localStorageExists) {
+      if (isLocalStorageValueValid) {
         // source of truth from localStorage
-        setClassOnDocumentBody(localStorageTheme);
+        setClassOnDocumentBody(localStorageValue);
       } else if (supportsColorSchemeQuery) {
         // source of truth from system
         setClassOnDocumentBody(mql.matches);