feat(placeholder-support): added placeholder for pickers #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in IOS it works perfect, as we implement picker in custom-keyboard component. - for android, we need to add an extra item in the `Picker.item` list as placeholder value. There is drawback of this approach in android that, the placeholder will appear as first value in drop-down list of picker
princeTPG
force-pushed
the
feat/placeholder-support
branch
from
29643bc to
37aba25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picker.itemlist as placeholder value.There is drawback of this approach in android that, the placeholder will appear as first value in drop-down list of picker
Added tag for this version as
v2.0.5+waam-app.9