Fix exoplayer aspect ratio update on source changes (TheWidlarzGroup#…

…2053) * Fix exoplayer aspect ratio update on source changes * Update CHANGELOG.md
waam-app · May 28, 2021 · 3181b70 · 3181b70
1 parent 20f4c26
commit 3181b70
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@
 - Added preventsDisplaySleepDuringVideoPlayback (#2019)
 - Reverted the JS fullscreening for Android. [#2013](https://github.com/react-native-community/react-native-video/pull/2013)
 - Set iOS request headers without needing to edit RCTVideo.m. [#2014](https://github.com/react-native-community/react-native-video/pull/2014)
+- Fix exoplayer aspect ratio update on source changes [#2053](https://github.com/react-native-community/react-native-video/pull/2053)
 
 ### Version 5.1.0-alpha5
 

diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/AspectRatioFrameLayout.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/AspectRatioFrameLayout.java
@@ -67,6 +67,10 @@ public float getAspectRatio() {
         return videoAspectRatio;
     }
 
+    public void invalidateAspectRatio() {
+        videoAspectRatio = 0;
+    }
+
     /**
      * Sets the resize mode which can be of value {@link ResizeMode.Mode}
      *

diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java
@@ -200,6 +200,11 @@ private void updateForCurrentTrackSelections() {
         shutterView.setVisibility(VISIBLE);
     }
 
+    public void invalidateAspectRatio() {
+        // Resetting aspect ratio will force layout refresh on next video size changed
+        layout.invalidateAspectRatio();
+    }
+
     private final class ComponentListener implements SimpleExoPlayer.VideoListener,
             TextOutput, ExoPlayer.EventListener {
 

diff --git a/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
@@ -410,6 +410,8 @@ public void run() {
                     player.setPlaybackParameters(params);
                 }
                 if (playerNeedsSource && srcUri != null) {
+                    exoPlayerView.invalidateAspectRatio();
+
                     ArrayList<MediaSource> mediaSourceList = buildTextSources();
                     MediaSource videoSource = buildMediaSource(srcUri, extension);
                     MediaSource mediaSource;