Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ipfs credential assign #231

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Fix ipfs credential assign #231

merged 2 commits into from
Oct 30, 2022

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Oct 13, 2022

Description

Managed IPFS credentials do not work in the docker container.

Relates to #210


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 45.51% // Head: 45.63% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (72d54d0) compared to base (046824c).
Patch has no changes to coverable lines.

❗ Current head 72d54d0 differs from pull request most recent head d6c8708. Consider uploading reports for the commit d6c8708 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   45.51%   45.63%   +0.12%     
==========================================
  Files          40       40              
  Lines        4998     4998              
==========================================
+ Hits         2275     2281       +6     
+ Misses       2445     2440       -5     
+ Partials      278      277       -1     
Impacted Files Coverage Δ
service/slack/slack.go 5.47% <0.00%> (+0.57%) ⬆️
service/service.go 69.69% <0.00%> (+12.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver self-assigned this Oct 27, 2022
@waybackarchiver waybackarchiver force-pushed the fix-ipfs-credential branch 2 times, most recently from 72d54d0 to d6c8708 Compare October 29, 2022 08:34
@waybackarchiver waybackarchiver merged commit 0c7b047 into main Oct 30, 2022
@waybackarchiver waybackarchiver deleted the fix-ipfs-credential branch October 30, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant