Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default path for the reduxer #235

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Set the default path for the reduxer #235

merged 2 commits into from
Oct 27, 2022

Conversation

waybackarchiver
Copy link
Contributor

Description

Set the default temporary path for the reduxer to avoid a fatal error.


Issue Ticket Number

Fixes #233


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 45.60% // Head: 45.51% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (fb0fac3) compared to base (f97f212).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   45.60%   45.51%   -0.09%     
==========================================
  Files          40       40              
  Lines        4993     4998       +5     
==========================================
- Hits         2277     2275       -2     
- Misses       2440     2445       +5     
- Partials      276      278       +2     
Impacted Files Coverage Δ
service/service.go 57.57% <42.85%> (-6.71%) ⬇️
config/options.go 93.54% <100.00%> (ø)
publish/matrix.go 48.33% <0.00%> (-5.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver merged commit 046824c into main Oct 27, 2022
@waybackarchiver waybackarchiver deleted the fix-reduxer branch October 27, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"reduxer unexpected" error
1 participant