Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements #335

Merged
merged 12 commits into from
Mar 21, 2023
Merged

Several improvements #335

merged 12 commits into from
Mar 21, 2023

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Mar 8, 2023

Description


Issue Ticket Number

Fixes #(issue_number)


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 32.16% and project coverage change: +0.23 🎉

Comparison is base (b2ac78f) 46.46% compared to head (6092c32) 46.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   46.46%   46.69%   +0.23%     
==========================================
  Files          57       58       +1     
  Lines        5172     5129      -43     
==========================================
- Hits         2403     2395       -8     
+ Misses       2506     2473      -33     
+ Partials      263      261       -2     
Impacted Files Coverage Δ
config/options.go 93.69% <ø> (ø)
reduxer/video.go 0.00% <0.00%> (ø)
storage/storage.go 73.68% <0.00%> (+15.78%) ⬆️
reduxer/media.go 35.29% <14.73%> (-47.64%) ⬇️
pooling/pooling.go 88.73% <25.00%> (-2.05%) ⬇️
reduxer/reduxer.go 64.43% <57.97%> (+23.38%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver force-pushed the improvement branch 5 times, most recently from 83efa65 to e1024fa Compare March 18, 2023 15:15
@waybackarchiver waybackarchiver marked this pull request as ready for review March 20, 2023 11:03
@waybackarchiver waybackarchiver changed the title Minor improvements Several improvements Mar 21, 2023
@waybackarchiver waybackarchiver merged commit 58f49f2 into main Mar 21, 2023
@waybackarchiver waybackarchiver deleted the improvement branch March 21, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant