Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the Tor binary #336

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Get rid of the Tor binary #336

merged 3 commits into from
Mar 14, 2023

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Mar 10, 2023

Description

We no longer require the tor binary as we have added an enhancement to be compatible with libtor. Instead, we can now build with the with_tor build tag using the command go build -tags with_tor.


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

We no longer require the tor binary as we have added an enhancement
to be compatible with libtor. Instead, we can now build with the
`embedded_tor` build tag using the command `go build -tags embedded_tor`.
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.79 🎉

Comparison is base (8488973) 45.72% compared to head (497dacb) 46.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   45.72%   46.51%   +0.79%     
==========================================
  Files          56       57       +1     
  Lines        5164     5172       +8     
==========================================
+ Hits         2361     2406      +45     
+ Misses       2545     2504      -41     
- Partials      258      262       +4     
Impacted Files Coverage Δ
service/httpd/tor.go 6.55% <0.00%> (+6.55%) ⬆️
service/httpd/web.go 26.99% <26.99%> (ø)
service/httpd/httpd.go 72.88% <75.00%> (+45.88%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver marked this pull request as ready for review March 14, 2023 05:11
@waybackarchiver waybackarchiver merged commit b2ac78f into main Mar 14, 2023
@waybackarchiver waybackarchiver deleted the libtor branch March 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant