Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting lux to pluggable mode #337

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Adjusting lux to pluggable mode #337

merged 4 commits into from
Mar 15, 2023

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented Mar 10, 2023

Description

By enabling pluggable mode, the size of the binary file can be reduced from 35MB to 26MB while maintaining compatibility with most streaming sites.


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 21.49% and project coverage change: +0.59 🎉

Comparison is base (b2ac78f) 46.46% compared to head (1552fa8) 47.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   46.46%   47.05%   +0.59%     
==========================================
  Files          57       58       +1     
  Lines        5172     5128      -44     
==========================================
+ Hits         2403     2413      +10     
+ Misses       2506     2452      -54     
  Partials      263      263              
Impacted Files Coverage Δ
reduxer/video.go 0.00% <0.00%> (ø)
reduxer/media.go 35.29% <14.73%> (-47.64%) ⬇️
reduxer/reduxer.go 62.76% <90.00%> (+21.70%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

By enabling pluggable mode, the size of the binary file can be reduced
from 35MB to 26MB while maintaining compatibility with most streaming sites.
@waybackarchiver waybackarchiver merged commit 142f095 into main Mar 15, 2023
@waybackarchiver waybackarchiver deleted the stub-lux branch March 15, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant