Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DFA analysis #839

Closed
5 tasks done
vincentvanhees opened this issue Jul 11, 2023 · 3 comments
Closed
5 tasks done

Implement DFA analysis #839

vincentvanhees opened this issue Jul 11, 2023 · 3 comments

Comments

@vincentvanhees
Copy link
Member

vincentvanhees commented Jul 11, 2023

Implement DFA analysis based on code provided by Ian.

To do:

  • Select variables to output (we only need ABI and SSP)
  • Decide which functions will be internal/external
  • Prepare functions with Rd file documentation and unit-test
  • Store variables in output
  • Merge with cosinor work which relates to same part of function g.part5
@vincentvanhees
Copy link
Member Author

Hi @iandanilevicz and @victormesquita40

This is a heads-up that I am now implementing the DFA, SSP and ABI functions you wrote last year:

  • Even though you are listed in the code as author, I will also add you as co-author to the git commit such that it is clear from the git history that you did the work. You will probably receive a notification about this.
  • I am preparing all this in a git branch which I will turn into a pull request later today. I will not merge the pull request without Ian's approval (we will meet on Friday).
  • I have made minor changes to the exception handling, which I will explain in the pull request. The algorithm itself is the same as how you provided it to me.

vincentvanhees added a commit that referenced this issue Jan 31, 2024
Co-Authored-By: Victor Barreto Mesquita <54644227+victormesquita40@users.noreply.github.com>
Co-Authored-By: Ian Danilevicz <43249776+iandanilevicz@users.noreply.github.com>
@victormesquita40
Copy link
Contributor

victormesquita40 commented Jan 31, 2024 via email

vincentvanhees added a commit that referenced this issue Feb 2, 2024
Co-Authored-By: Victor Barreto Mesquita <54644227+victormesquita40@users.noreply.github.com>
Co-Authored-By: Ian Danilevicz <43249776+iandanilevicz@users.noreply.github.com>
@vincentvanhees
Copy link
Member Author

Close this issue, because this is covered by #955 and will be merged paper has been written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants