Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stoll: no conversion" error when GGIRread::readGENEActiv tries reading mode data than available #58

Closed
l-k- opened this issue Feb 8, 2024 · 0 comments · Fixed by #59
Assignees

Comments

@l-k-
Copy link
Collaborator

l-k- commented Feb 8, 2024

Whenever readGENEActiv() gets a request for a block of data that is bigger than what's left in the file, we get an error that looks like this: "data error at i = %d: %s i: 231 stoll: no conversion"

Below is a screenshot of this error during execution of test_greadaccfile GGIR test:

image

This is triggered by an attempt to read past the end of the file, and in this context it's really not an error but an expected signal that we reached the end of the file. When more data is requested than available, readGENEActiv() simply returns what's available; this is normal behavior, not an error.

So there's no need to print out an error, in red, making it look like something went wrong.

Also, string formatting for the error messages needs to be fixed (it looks like the printf-style formatting is used with streams).

I will send a PR to address this.

@l-k- l-k- self-assigned this Feb 8, 2024
vincentvanhees added a commit that referenced this issue Feb 28, 2024
Issue #58 Don't print error when more data is requested from readGENEActiv() than is available in the file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant