Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added progress bar fix for axivity #64

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

muschellij2
Copy link
Contributor

Fix #63 - moves the code for progress bar to after nr is defined.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

@muschellij2
Copy link
Contributor Author

RStudio apparently stylized the files for whitespace by default, easier to see diffs using https://github.com/wadpac/GGIRread/pull/64/files?w=1

muschellij2 added a commit to muschellij2/SummarizedActigraphy that referenced this pull request Apr 8, 2024
… for errors, otherwise may want to set progressBar=FALSE by default
Copy link
Member

@vincentvanhees vincentvanhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muschellij2, I will merge this now but will wait with a new CRAN release until May just in case more updates are needed.

@vincentvanhees vincentvanhees merged commit cf9ba6c into wadpac:main Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgresBar failing for readAxivity
2 participants