Skip to content

Commit

Permalink
DIVE_VERSION does not need to be exported (#492)
Browse files Browse the repository at this point in the history
The value of the variable DIVE_VERSION is not needed in a
spawned subprocess. Thus, the variable does not necessarily
need to be exported. Arguably, the environment is less
polluted if it is not exported.
  • Loading branch information
ReneNyffenegger authored Feb 2, 2024
1 parent 2d86aa7 commit 7556be3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ With valid `source` options as such:

Using debs:
```bash
export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/')
DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/')
curl -OL https://github.com/wagoodman/dive/releases/download/v${DIVE_VERSION}/dive_${DIVE_VERSION}_linux_amd64.deb
sudo apt install ./dive_${DIVE_VERSION}_linux_amd64.deb
```
Expand All @@ -112,7 +112,7 @@ sudo snap connect dive:docker-daemon docker:docker-daemon

**RHEL/Centos**
```bash
export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/')
DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^"]+)".*/\1/')
curl -OL https://github.com/wagoodman/dive/releases/download/v${DIVE_VERSION}/dive_${DIVE_VERSION}_linux_amd64.rpm
rpm -i dive_${DIVE_VERSION}_linux_amd64.rpm
```
Expand Down

0 comments on commit 7556be3

Please sign in to comment.