Add CI integration #143
Merged
Add CI integration #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
force-pushed
the
ci-integration
branch
from
726bed8 to
1bf3be1
Compare
Makefile
Outdated
| ./build/$(BIN) build -t dive-example:latest -f .data/Dockerfile.example . | ||
|
|
||
| run-ci: build | ||
| CI=true ./build/$(BIN) build -t dive-example:latest -f .data/Dockerfile.example . |
There was a problem hiding this comment.
Can we add --ci-config ./.data/.dive-ci?
The default rules make sense, but I think the defile behavior of make run-ci should exercise all the rules, and not skip the wasted bytes rule.
README.md
Outdated
| @@ -16,6 +16,13 @@ or if you want to build your image then jump straight into analyzing it: | |||
| dive build -t <some-tag> . | |||
| ``` | |||
|
|
|||
| Additionally you can run this in your CI pipeline to ensure you're keeping wasted space to a minimum (this skips the TUI): | |||
There was a problem hiding this comment.
Did you mean this skips the UI not this skips the TUI?
There was a problem hiding this comment.
TUI = terminal UI, but UI makes more sense universally
willmurphyscode
approved these changes
Dec 30, 2018
DeanAyalon
pushed a commit
to DeanAyalon/fork-dive
that referenced
this pull request
Oct 17, 2024
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 27.0.1+incompatible to 27.0.2+incompatible. - [Commits](docker/cli@v27.0.1...v27.0.2) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an opportune time to take care of a few things:
--json)closes #74