Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #159

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Update README.md #159

merged 1 commit into from
Feb 19, 2019

Conversation

Sarke
Copy link
Contributor

@Sarke Sarke commented Feb 15, 2019

Incorrect config file location

Incorrect config file location
Copy link
Owner

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, as written is how dive behaves:

$ dive alpine:latest
Using config file: /home/agoodman/.config/dive/config.yaml
Fetching image... (this can take a while with large images)
...

@wagoodman wagoodman closed this Feb 19, 2019
@Sarke
Copy link
Contributor Author

Sarke commented Feb 19, 2019

@wagoodman No, not the latest release.

After some looking around, it seems this was updated very recently:
https://github.com/wagoodman/dive/pull/152/files#diff-04c6e90faac2675aa89e2176d2eec7d8

However, the latest release, which is v0.6.0 for deb, rpm, and docker hub, doesn't not read ~/.config/dive/config.yaml. So yeah, big waste of time going by the documentation not related to he latest release.

Most people will be on the release, not using the master branch.

@wagoodman
Copy link
Owner

wagoodman commented Feb 19, 2019

Good catch. It could be a while before I cut the next release, so updating the doc in the meantime makes sense.

@wagoodman wagoodman reopened this Feb 19, 2019
@wagoodman wagoodman merged commit cf8900d into wagoodman:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants