Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream podman command hanging #349

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

hedrox
Copy link
Contributor

@hedrox hedrox commented Apr 11, 2021

I found that using an image that is not in podman locally would hang dive. It seems like this writer not being closed on the streamPodmanCmd function was the culprit.
To test this issue, fist make sure ubuntu is not in podman and then the outputs should be:

Before:

$ dive podman://docker.io/library/ubuntu
Image Source: podman://docker.io/library/ubuntu
Fetching image... (this can take a while for large images)
Error: unable to find 'docker.io/library/ubuntu' in local storage: no such image
(here it will hang)

After:

$ dive podman://docker.io/library/ubuntu
Image Source: podman://docker.io/library/ubuntu
Fetching image... (this can take a while for large images)
Error: unable to find 'docker.io/library/ubuntu' in local storage: no such image
cannot fetch image
unable to resolve image 'docker.io/library/ubuntu': could not find image manifest

Copy link
Owner

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants