Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests using pytest #76

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Run tests using pytest #76

merged 3 commits into from
Apr 24, 2024

Conversation

mgax
Copy link
Member

@mgax mgax commented Apr 23, 2024

Fix #74.

Here is a successful CI run with essentially the same changeset: https://github.com/mgax/wagtail-newsletter/actions/runs/8802487283.

@mgax mgax marked this pull request as ready for review April 23, 2024 14:50
@chris48s
Copy link
Contributor

I'll try and have a proper look over this one later this week.

Copy link
Contributor

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - couple of minor bits but mostly 👍

{{ cookiecutter.__project_name_kebab }}/pyproject.toml Outdated Show resolved Hide resolved
{{ cookiecutter.__project_name_kebab }}/ruff.toml Outdated Show resolved Hide resolved
@mgax
Copy link
Member Author

mgax commented Apr 24, 2024

@chris48s thanks for the review! I've sorted the comments.

@chris48s chris48s merged commit 2e10f46 into wagtail:main Apr 24, 2024
4 checks passed
@mgax mgax deleted the pytest branch April 24, 2024 15:28
@mgax mgax mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt pytest as our go-to test runner
2 participants