Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 53: Swappable Page model #53

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

sonnybaker
Copy link

@sonnybaker sonnybaker commented Jun 22, 2020

@sonnybaker sonnybaker changed the title RFC 000: Swappable Page models RFC 000: Swappable Page model Jun 22, 2020
@sonnybaker sonnybaker changed the title RFC 000: Swappable Page model RFC 53: Swappable Page model Jun 22, 2020
@mattlinares
Copy link

This would be great. Is this still alive? :)

@NotANormalNerd
Copy link

This would be an amazing solution to a problem we have right now. We are not happy with how pages are identified by Wagtail, so we would like to introduce another PageIdentifier. Right now we can have a ParentalKey to another Model but that handling is just not elegant for something that should essentially be a CharField.

I think this would add a lot of value and possibilities to Wagtail Development. And with django-swappable-models there is even some experience here.

@thibaudcolas
Copy link
Member

Thank you @sonnybaker for taking a crack at this, I can only imagine it being very tough to write an RFC for this.

Linking to historical discussion for reference: Feature request: Swappability of main models #11381


@mattlinares @NotANormalNerd, and anyone who wonders where this is at – if you want to see this happen,

  1. Review the RFC and provide feedback
  2. Get your friends to review the RFC
  3. Discuss this in place with the Wagtail Slack

We’re not particularly good at this RFC process but if there’s movement I’m sure the core team will make efforts to support this.

@sonnybaker
Copy link
Author

Hi @thibaudcolas! Thanks so much for resurrecting this. It's fair to say Wagtail has come on a little bit since I wrote this back in 2020, so there's obviously a lot more to factor in now (new revisions sytem and comments immediately spring to mind). We're keen to get behind this at at Hactar, so would love to work on the PR/epic with the guidance of the core team if there's an appetite for it to move forward.

@lb-
Copy link
Member

lb- commented Jan 10, 2024

Please note, we have closed the PR wagtail/wagtail#5457 & raised an issue to reflect that goal instead wagtail/wagtail#11440

It might be worth updating this RFC to reflect that in the links section.

@allcaps
Copy link
Member

allcaps commented Jul 18, 2024

A use-case that could benefit coderedcorp/wagtail-seo#43 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants