-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollbars appearance in Darkmode #204
Comments
Can you override the system scroll bar styles with CSS alone? Why is there even scroll bars around the page TOC? I feel having the page TOC static would be ok and not as annoying as the previously static main TOC. And the horizontal scrolling should definitely be avoided. |
Yes, I think we can.
I added it because there was an issue for it |
Ah, fair enough. I forget which page was the use case. But i guess preventing horizontal would still be good |
I agree preventing horizontal scrolling would be good and an action from this issue. I am not convinced styling the scrollbar is a good option, I think that it can come across as tacky and it works against the OS's decision on styling here. However, we could look at just using the slimmer scrollbar-width option.
But it might be a while before browsers support it, however, it could be added with a comment that it will work as browsers adopt it. |
Note - the PR #215 only fixed the horizontal scroll but I think that is sufficient for now. If we feel that we must do some other styling hacks to change the look of the scroll bars we can raise a new issue. |
There comes a point when there are 3 vertical scrollbars and 1 horizontal scrollbar on one page, which looks a bit odd, particularly in dark mode.
In dark mode:
In light mode:
Quick fixes I have in mind:
Actions
scrollbar-width: thin;
to the inner and main TOC containers with a note about progressive adoptionThe text was updated successfully, but these errors were encountered: