Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link style in Safari #160

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix link style in Safari #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sass/_component_link.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
a {
color: $link-color;
text-decoration: 2px solid underline;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop this line now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if that would have unintended side effects in other browsers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked on mdn web docs. All browsers support long hand versions. Only Firefox for Android doesn't support text-decoration-thickness neither in short nor in long hand way. So I think removing it will be safe.

text-decoration-line: underline;
text-decoration-style: solid;
text-decoration-thickness: 2px;
text-decoration-color: $link-border-color;
text-underline-offset: 3px;

Expand All @@ -9,10 +12,12 @@ a {
color: $link-hover-color;
// This is necessary because of some weird `hover` mixin in bootstrap.
text-decoration: 2px solid underline;
text-decoration-color: currentcolor;
}

&:active {
color: $link-active-color;
text-decoration: 2px solid underline;
text-decoration-color: currentcolor;
}
}