Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table of contents sidebar overlapping with EthicalAds placement #295

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix table of contents sidebar overlapping with EthicalAds placement #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions sass/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,3 +208,19 @@ $grid-gutter-width: 40px;
// --------------------------------------------------

$medium-width: 768px;

// --------------------------------------------------
// Z-index
// https://getbootstrap.com/docs/4.6/layout/overview/#z-index
// Lower the default z-index values to avoid conflicts with EthicalAds placement
// on readthedocs.org.
// See also: https://github.com/readthedocs/ethical-ad-client/pull/196
// --------------------------------------------------

$zindex-dropdown: 10;
$zindex-sticky: 20;
$zindex-fixed: 30;
$zindex-modal-backdrop: 40;
$zindex-modal: 50;
$zindex-popover: 60;
$zindex-tooltip: 70;
Comment on lines +220 to +226
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap's docs says the following:

We don’t encourage customization of these individual values; should you change one, you likely need to change them all.