-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinterest embed support #8122
Pinterest embed support #8122
Conversation
Manage this branch in SquashTest this branch here: https://dharma-09pinterest-embed-suppo-elpwe.squash.io |
Hey @thibaudcolas any comment on this?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dharma-09 thanks so much for taking the time to contribute but please advise how you tested it.
I checked out this branch, tried entering
https://www.pinterest.com/villabalicom/must-visit-places-in-bali/
and I got an error
It appears Pinterest is also adding country domains to their redirects, I originally tried
https://www.pinterest.com.au/viatortravel/bali-things-to-do/
and got the same error.
I might be missing something but please can you update the original request or the PR description on how you expect this to work (maybe some example URLs and then a screenshot).
@lb- I have implemented pull request and add some regex.Error occurs because of bed regex.Now, it's working.You can review it now 🚀.
|
@Dharma-09 awesome. I'll take another look and hopefully can plan a trip to Bali haha. |
a679854
to
a86e257
Compare
- resolves wagtail#5471
a86e257
to
34d271c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Dharma-09 - I made a slight tweak to the regex to allow other TLDs but validated fine this time round.
I have put your name on the contributors list 'Dharmik Gangani' - please let me know if you wanted your name listed differently.
Will merge in shortly, congrats on making your first contribution to Wagtail.
Thank you!
Thanks @lb- Looking for more contribution in wagtail. |
fixed #5471