Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS not respecting wails.json #3200

Open
precisionpete opened this issue Jan 14, 2024 · 2 comments
Open

MacOS not respecting wails.json #3200

precisionpete opened this issue Jan 14, 2024 · 2 comments
Labels
Bug Something isn't working

Comments

@precisionpete
Copy link

precisionpete commented Jan 14, 2024

Description

Similar to the issue with Wails not following the wails build output filename on macos, it is not following the wails.json settings either for macos.

To Reproduce

{
"$schema": "https://wails.io/schemas/config.v2.json",
"name": "Myapp",
"outputfilename": "myapp-ui",
"frontend:install": "npm install",
"frontend:build": "npm run build",
"frontend:dev:watcher": "npm run dev",
"frontend:dev:serverUrl": "auto",
"wailsjsdir": "./frontend/src/lib",
"author": {
"name": "MyCo Inc.",
"email": "info@myco.ca"
}

run wails build on Linux and you get a file 'build/bin/netrinos-ui'

run wails build on macOS and you get build/bin/Myapp.app/Contents/MacOS/Myapp

Expected behaviour

should produce build/bin/Myapp.app/Contents/MacOS/myapp-ui

Screenshots

No response

Attempted Fixes

I will either rename things or maybe try a manual build.

System Details

MacOS Sonoma amd64

Additional context

It's not a big deal but I just wanted to document it.

@precisionpete precisionpete added the Bug Something isn't working label Jan 14, 2024
@plutov
Copy link
Contributor

plutov commented Jun 18, 2024

@leaanthony I think this should fix it

plutov added a commit to plutov/wails that referenced this issue Jun 19, 2024
leaanthony added a commit that referenced this issue Jul 19, 2024
* Use OutputFilename instead of Name

* #3200: add changelog entry

---------

Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
@leaanthony
Copy link
Member

@precisionpete - I've merged the above PR. If you're able to test master for the fix, that would be amazing. Thank you! 🙏

therealsamf pushed a commit to therealsamf/wails that referenced this issue Aug 29, 2024
* Use OutputFilename instead of Name

* wailsapp#3200: add changelog entry

---------

Co-authored-by: Lea Anthony <lea.anthony@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants