Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3-Linux] Upgrade to Webkitgtk4.1 #3461

Merged
merged 6 commits into from
May 8, 2024

Conversation

atterpac
Copy link
Member

@atterpac atterpac commented May 7, 2024

Description

Breaking change for linux. Upgrades dependencies for webkitgtk4.0 to 4.1 due to latest Ubuntu 24.04 LTS not having 4.0 available.

Fixes # (issue)
Wails on Ubuntu 24.04 LTS

Please delete options that are not relevant.

  • [ X ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • [ X ] Linux

Test Configuration

| Name         | Ubuntu                             |
| Version      | 22.04                              |
| ID           | ubuntu                             |
| Branding     | 22.04.4 LTS (Jammy Jellyfish)      |
| Platform     | linux                              |
| Architecture | amd64                              |
| CPU          | AMD Ryzen 7 3700X 8-Core Processor |
| GPU 1        | Unknown                            |
| Memory       | 12GB                               |

# Build Environment
| Wails CLI      | v3.0.0-alpha.4                                                                 |
| Go Version     | go1.22.2                                                                       |
| Revision       | 5a57ee99ac5dc0910ce11b0eb458849f98b38a49                                       |
| Modified       | true                                                                           |
| -buildmode     | exe                                                                            |
| -compiler      | gc                                                                             |
| CGO_CFLAGS     |                                                                                |
| CGO_CPPFLAGS   |                                                                                |
| CGO_CXXFLAGS   |                                                                                |
| CGO_ENABLED    | 1                                                                              |
| CGO_LDFLAGS    |                                                                                |
| DefaultGODEBUG | httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1 |
| GOAMD64        | v1                                                                             |
| GOARCH         | amd64                                                                          |
| GOOS           | linux                                                                          |
| vcs            | git                                                                            |
| vcs.modified   | true                                                                           |
| vcs.revision   | 5a57ee99ac5dc0910ce11b0eb458849f98b38a49                                       |
| vcs.time       | 2024-05-03T17:52:15Z                                                           |

# Dependencies
| pkg-config | 0.29.2-1ubuntu3         |
| gcc        | 12.9ubuntu3             |
| libgtk-3   | 3.24.33-1ubuntu2        |
| libwebkit  | 2.44.0-0ubuntu0.22.04.1 |
| npm        | 10.7.0                  |

@atterpac atterpac force-pushed the webkit-version-up branch from 9ba8045 to 33761c6 Compare May 7, 2024 21:23
@leaanthony leaanthony self-requested a review May 8, 2024 07:47
@leaanthony leaanthony self-requested a review May 8, 2024 07:53
@leaanthony leaanthony self-requested a review May 8, 2024 07:56
@leaanthony leaanthony merged commit 71b2edc into wailsapp:v3-alpha May 8, 2024
8 checks passed
@fdidron
Copy link
Contributor

fdidron commented May 8, 2024

@atterpac @leaanthony Does it make sense backporting this to v2 (master) ?
If it does, happy to send over a PR :)

@leaanthony
Copy link
Member

Hey @fdidron 👋 I'm not sure how many current distros have 4.1 available to them so can't really assess the impact of backporting it.

@atterpac
Copy link
Member Author

atterpac commented May 8, 2024

Hey @fdidron 👋 I'm not sure how many current distros have 4.1 available to them so can't really assess the impact of backporting it.

Looking through to double check but it looks like the major couple OS's 4.1 is supported on the last ~3 versions
all arch distros will be fine because that's what arch is for
Ubuntu has support for it for the last 3 LTS versions, looks out of date anything before jammy
Fedora/RedHat seems to support it from 37+ and up as well as killing off 4.0 in Fedora 40s upcoming release

Seems like the move to 4.1 will need to happen in some form but maybe that takes the form of a build flag to set what dependency should be compiled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants