Allow dynamic views add/remove #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference to: wajahatkarim3#9 Needs verification for the standard usage with XML: - If someone can test it with standard usage as it was without this PR, so by inflating using XML layout would be awesome, otherwise a bit more patience and i'll be free to test it in 7/8 hours. I can't see anything that could break the usage with XML. Dynamic is working fine as I'm actually using it on a corporate project.
|
There is a little problem with this that just came to my mind. I need to add a couple of lines ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to: #9
Needs verification for the standard usage with XML:
I can't see anything that could break the usage with XML. Dynamic is working fine as I'm actually using it on a corporate project.