Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display "total time today" in status bar #144

Merged
merged 1 commit into from
May 23, 2023
Merged

Display "total time today" in status bar #144

merged 1 commit into from
May 23, 2023

Conversation

JasonWei512
Copy link
Contributor

Solve #108.

Waiting for wakatime/nuget-wakatime-shared-extension-utils#7 to be merged first.

image

image

@JasonWei512 JasonWei512 mentioned this pull request May 15, 2023
Closed
@alanhamlett
Copy link
Member

We'll need to bump the nuget package version and use that new version here.

@JasonWei512 JasonWei512 changed the title Display "total time today" in status bar Display "total time today" in status bar in Visual Studio 2022 May 15, 2023
@JasonWei512 JasonWei512 mentioned this pull request May 15, 2023
Merged
@gandarez gandarez self-requested a review May 16, 2023 01:06
@JasonWei512
Copy link
Contributor Author

https://github.com/wakatime/visualstudio-wakatime/pull/144/files#diff-b086968dd4a86b427e559c123646a991b0286dc2fbcb3c6bc39355f14015014c

Somehow I triggerred Visual Studio's code cleanup. Many var are replaced with explicit types. Sorry about that.

@JasonWei512 JasonWei512 force-pushed the feature/today-coding-time-develop branch from 85d6754 to ad24db2 Compare May 16, 2023 11:38
@JasonWei512
Copy link
Contributor Author

Fixed.

gandarez
gandarez requested changes May 18, 2023
View reviewed changes
Copy link
Member

@gandarez gandarez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into one or maximum two and update the nuget library to v4.2.0. This project supports different versions so the changes must be applied to Dev14 and Dev16 as well.

Dev17/ExtensionUtils/StatusbarInjector.cs Outdated Show resolved Hide resolved
Dev17/ExtensionUtils/StatusbarControl.cs Outdated Show resolved Hide resolved
@JasonWei512 JasonWei512 force-pushed the feature/today-coding-time-develop branch from ad24db2 to c212560 Compare May 19, 2023 11:44
@JasonWei512
Copy link
Contributor Author

Done.

@JasonWei512 JasonWei512 changed the title Display "total time today" in status bar in Visual Studio 2022 Display "total time today" in status bar May 19, 2023
@JasonWei512 JasonWei512 requested a review from gandarez May 23, 2023 05:25
@alanhamlett alanhamlett merged commit 779e2e9 into wakatime:master May 23, 2023
@alanhamlett
Copy link
Member

Thank you!

@guibranco guibranco mentioned this pull request May 25, 2023
Closed
@guibranco
Copy link

@alanhamlett when this PR will be released? The last release was on Dec 2022.

@alanhamlett
Copy link
Member

Yes, we're working on that so hopefully this week we can do a release. We need to fix #145 too.

@gandarez gandarez self-assigned this Jul 3, 2023
@gandarez
Copy link
Member

gandarez commented Jul 3, 2023

Released v13.1.0 in the marketplace with this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandarez gandarez Awaiting requested review from gandarez

Assignees

@gandarez gandarez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonWei512 @alanhamlett @guibranco @gandarez