-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support global WakaTime installation #178
Support global WakaTime installation #178
Conversation
I need this to get NixOS working - would love to see this merged. |
I'll give this a clean up tomorrow if there's someone else waiting for it then so if you do decide to go ahead with it it can be done quicker. @jakeisnt In the meantime, if it's acceptable to you, adding |
Unfortunately, installing python37 doesn't do it for me - all my extensions are installed declaratively, and because they're saved as Nix derivations, the extension can't pull down the |
That link's into a private repo unfortunately so I can't see it - although if you'd be willing to publish it as a gist or something I'd be interested to see how you're doing that. Working on cleaning this up now 🙂 |
I just gave you the wrong link - try this! https://github.com/jakeisnt/nix-cfg/blob/master/modules/editors/vscode.nix |
I've rebased onto master and changed a couple of fatal logs into errors to quit out if there's no global installation. It works for me using a global or non-global installation with |
Remove 'WIP' from the title and request a review! |
Doh! Thanks 😂 |
@jakeisnt I've followed your example and configured all my VSCode extensions in my nixos config as well now. Although I'm going to have to switch back to manual installs until this is merged as you can't mix the two 😭 @alanhamlett is there any chance you could take a look at this? |
Would it be possible to get a release candidate for this? |
Released in v5.0.1 today. |
Thank you |
This is quick-and-dirty for the moment but I'll clean it up if you think it's worth adding as an option. For systems like NixOS ones where the paths are unpredictable, I added a dependency on node-which. This could also replace or be used alongside the current search for python, although the existing method found my python executable fine.
Feel free to flat-out reject this if it goes against what you're aiming for in terms of config surface etc.
Closes #177.