Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSCode setting for API key #318

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Add VSCode setting for API key #318

merged 3 commits into from
Jan 13, 2023

Conversation

kotx
Copy link
Contributor

@kotx kotx commented Jan 8, 2023

Resolves #283.
I was not able to test it for the VSCode Web extension, but in theory it should work.

Here's what it looks like:
image
image

Now setting the API key from the prompt (WakaTime: Api Key command) will also set it in VSCode global settings. Let me know if this should not be the case.
VSCode Settings Sync is also enabled for the API key.

@alanhamlett
Copy link
Member

Let's not set it by default from the prompt, only when set in the settings directly. Otherwise, a lot of people not running in dev containers will get confused when their vscode api key becomes out of sync with their ~/.wakatime.cfg api key.

@kotx
Copy link
Contributor Author

kotx commented Jan 13, 2023

@alanhamlett Should be fine now!

@alanhamlett alanhamlett merged commit bfeedb7 into wakatime:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the wakatime api key to be persisted via settings sync
2 participants