Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Portable Mode #91

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Support for Portable Mode #91

merged 4 commits into from
Apr 17, 2019

Conversation

gandarez
Copy link
Member

  • consider portable mode when calling getUserHomeDir
  • add new commands
  • use string interpolation

@gandarez gandarez mentioned this pull request Apr 16, 2019
Closed
alanhamlett
alanhamlett requested changes Apr 17, 2019
View reviewed changes
Copy link
Member

@alanhamlett alanhamlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renaming 2 functions, it's great!

src/wakatime.ts Outdated Show resolved Hide resolved
src/wakatime.ts Outdated Show resolved Hide resolved
@gandarez gandarez self-assigned this Apr 17, 2019
@gandarez
Copy link
Member Author

@alanhamlett done!

@alanhamlett alanhamlett merged commit f9f5a1b into wakatime:master Apr 17, 2019
@alanhamlett
Copy link
Member

Thank you!

@jgmuchiri
Copy link

@gandarez @alanhamlett Thank you guys for addressing this!

@alanhamlett alanhamlett changed the title New features Support for Portable Mode Apr 17, 2019
@alanhamlett alanhamlett mentioned this pull request Oct 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhamlett alanhamlett alanhamlett approved these changes

Assignees

@gandarez gandarez

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gandarez @alanhamlett @jgmuchiri