Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate required fields for fileexperts #920

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

gandarez
Copy link
Member

This PR validates required fields to avoid bad request before calling file experts endpoint.

Fix #919

@gandarez gandarez self-assigned this Aug 27, 2023
Copy link
Member

@alanhamlett alanhamlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gandarez gandarez force-pushed the bugfix/file-experts-required-fields branch from 9345597 to 09c6139 Compare August 27, 2023 13:21
@gandarez gandarez merged commit 8b2fb25 into develop Aug 27, 2023
9 checks passed
@gandarez gandarez deleted the bugfix/file-experts-required-fields branch August 27, 2023 13:26
@alanhamlett alanhamlett mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug parsing file expert JSON response
2 participants