-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter stats mismatch and add bad peer check for light mode #1241
Conversation
Jenkins BuildsClick to see older builds (3)
|
ac9241b
to
9c4ab85
Compare
9c4ab85
to
c4fd528
Compare
@siddarthkay not sure why the nix-build is failing, i have tried rerunning it but still fails. can you take a look? |
@chaitanyaprem : works now |
Thanks a lot! was it some sort of temporary failure or something you had to fix? |
temp failure on linux-03 host |
c4fd528
to
3546adf
Compare
c6c6479
to
6bdf125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only question i have is if these logs could be too noisy to have them at Info level
hmm, good point...will make them debug. |
3546adf
to
653e7b5
Compare
Description
While debugging filter issue, noticed that filter stats are mismatched because once a filter is removed it is still left in filtersubscriptions list in filterManager causing logs to be inconsistent.
Also added a minor bad peer removal functionality for light nodes based on dial error count. This may help improve lightnode connectivity and reduce failures.
Logic is simple: