Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter stats mismatch and add bad peer check for light mode #1241

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

chaitanyaprem
Copy link
Collaborator

Description

While debugging filter issue, noticed that filter stats are mismatched because once a filter is removed it is still left in filtersubscriptions list in filterManager causing logs to be inconsistent.

Also added a minor bad peer removal functionality for light nodes based on dial error count. This may help improve lightnode connectivity and reduce failures.
Logic is simple:

  1. Consider a peer as bad-peer if its dial error count is more than 3.
  2. Keep checking for such bad peers and remove them every 1 minute.

@chaitanyaprem chaitanyaprem changed the title fix filter stats mismatch and add bad peer check for light mode fix: filter stats mismatch and add bad peer check for light mode Oct 15, 2024
@status-im-auto
Copy link

status-im-auto commented Oct 15, 2024

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ac9241b #1 2024-10-15 13:58:10 ~1 min unknown 📄log
✔️ 9c4ab85 #2 2024-10-15 14:07:56 ~2 min unknown 📄log
✔️ c4fd528 #5 2024-10-16 10:17:50 ~2 min unknown 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3546adf #6 2024-10-18 10:49:18 ~1 min unknown 📄log
✔️ 653e7b5 #7 2024-10-28 06:06:10 ~2 min unknown 📄log

@chaitanyaprem chaitanyaprem force-pushed the fix/filter-stats-mismatch branch from ac9241b to 9c4ab85 Compare October 15, 2024 14:05
@chaitanyaprem chaitanyaprem force-pushed the fix/filter-stats-mismatch branch from 9c4ab85 to c4fd528 Compare October 16, 2024 02:02
@chaitanyaprem
Copy link
Collaborator Author

@siddarthkay not sure why the nix-build is failing, i have tried rerunning it but still fails. can you take a look?

@siddarthkay
Copy link
Contributor

@chaitanyaprem : works now

@chaitanyaprem
Copy link
Collaborator Author

@chaitanyaprem : works now

Thanks a lot! was it some sort of temporary failure or something you had to fix?

@siddarthkay
Copy link
Contributor

temp failure on linux-03 host

Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only question i have is if these logs could be too noisy to have them at Info level

@chaitanyaprem
Copy link
Collaborator Author

LGTM. The only question i have is if these logs could be too noisy to have them at Info level

hmm, good point...will make them debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants