feat: add option to specify preferred peers for filter #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
chaitanyaprem
force-pushed
the
feat/filter-preferred-peers
branch
2 times, most recently
from
e4241c1 to
d39200f
Compare
richard-ramos
approved these changes
Oct 25, 2024
kaichaosun
approved these changes
Oct 26, 2024
chaitanyaprem
force-pushed
the
fix/filter-stats-mismatch
branch
from
3546adf to
653e7b5
Compare
chaitanyaprem
force-pushed
the
feat/filter-preferred-peers
branch
from
d39200f to
b380474
Compare
chaitanyaprem
force-pushed
the
feat/filter-preferred-peers
branch
from
b380474 to
d81465e
Compare
|
Closing this as changes are being considered in #1244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added functionality to specify preferred-peers for filter. One of the peers used for filter subscription out of n will be randomly chosen from list of preferred peers.
In case of status this is meant to increase filter subscription success-rate as fleet nodes will be specified as filter-peers.
once this is dogfooded, lightpush can also be modified to use same logic.
status-go pr including these changes status-im/status-go#5964