Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: concurrent peerMap iteration and write #1266

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: concurrent peerMap iteration and write #1266

merged 1 commit into from
Dec 12, 2024

Conversation

qfrank
Copy link
Collaborator

@qfrank qfrank commented Dec 12, 2024

IMG_0467

@qfrank qfrank requested a review from plopezlpz December 12, 2024 10:32
@qfrank qfrank self-assigned this Dec 12, 2024
@status-im-auto
Copy link

status-im-auto commented Dec 12, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4848017 #1 2024-12-12 10:35:12 ~2 min unknown 📄log
✔️ 5bb97d2 #2 2024-12-12 10:40:08 ~2 min unknown 📄log

@qfrank qfrank force-pushed the fix/peer-map-concurrent-issue branch from 4848017 to 5bb97d2 Compare December 12, 2024 10:37
chaitanyaprem
chaitanyaprem approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Interesting that this is not detected by go race detector.

@qfrank qfrank merged commit ffed059 into master Dec 12, 2024
12 checks passed
@qfrank qfrank deleted the fix/peer-map-concurrent-issue branch December 12, 2024 10:46
@richard-ramos richard-ramos mentioned this pull request Dec 12, 2024
Open
plopezlpz pushed a commit that referenced this pull request Dec 12, 2024
@qfrank @plopezlpz
fix: concurrent peerMap iteration and write (#1266)
db978b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@plopezlpz plopezlpz plopezlpz approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees

@qfrank qfrank

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qfrank @status-im-auto @plopezlpz @chaitanyaprem