Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dns discovery in lib #884

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat: add dns discovery in lib #884

merged 3 commits into from
Nov 13, 2023

Conversation

harsh-98
Copy link
Contributor

@harsh-98 harsh-98 commented Nov 9, 2023

Description

Referring to waku-org/waku-rust-bindings#52. Add logic first to go-waku.

Changes

  • Add common logic for getting dns discovered nodes and creating discv5 service.
  • Add discv5 capability to library.

Tests

  • add previous test passing

@status-im-auto
Copy link

status-im-auto commented Nov 9, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (19)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 05e3b52 #1 2023-11-09 05:50:55 ~1 min linux 📄log
✔️ 05e3b52 #1 2023-11-09 05:51:30 ~1 min nix-flake 📄log
✔️ 05e3b52 #1 2023-11-09 05:53:18 ~3 min tests 📄log
✔️ 05e3b52 #1 2023-11-09 05:53:49 ~4 min tests 📄log
✔️ 05e3b52 #1 2023-11-09 05:53:57 ~4 min android 📦tgz
❌ 05e3b52 #2 2023-11-09 05:54:46 ~28 sec linux 📄log
✔️ 05e3b52 #1 2023-11-09 05:55:41 ~6 min ios 📦tgz
❌ 7b6c438 #3 2023-11-09 06:01:04 ~37 sec linux 📄log
✔️ 7b6c438 #2 2023-11-09 06:02:20 ~1 min nix-flake 📄log
✔️ 7b6c438 #2 2023-11-09 06:02:58 ~2 min tests 📄log
✔️ 7b6c438 #2 2023-11-09 06:03:58 ~3 min android 📦tgz
✔️ 7b6c438 #2 2023-11-09 06:04:10 ~3 min tests 📄log
✔️ 7b6c438 #2 2023-11-09 06:04:55 ~4 min ios 📦tgz
✔️ 9ad1721 #3 2023-11-09 06:08:18 ~1 min tests 📄log
❌ 9ad1721 #4 2023-11-09 06:08:38 ~1 min linux 📄log
✔️ 9ad1721 #3 2023-11-09 06:09:06 ~1 min nix-flake 📄log
✔️ 9ad1721 #3 2023-11-09 06:09:35 ~2 min tests 📄log
✔️ 9ad1721 #3 2023-11-09 06:10:22 ~3 min android 📦tgz
✔️ 9ad1721 #3 2023-11-09 06:11:07 ~3 min ios 📦tgz
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c9ab003 #5 2023-11-09 06:13:55 ~1 min linux 📦deb
✔️ c9ab003 #4 2023-11-09 06:13:57 ~1 min tests 📄log
✔️ c9ab003 #4 2023-11-09 06:14:41 ~1 min nix-flake 📄log
✔️ c9ab003 #4 2023-11-09 06:15:11 ~2 min tests 📄log
✔️ c9ab003 #4 2023-11-09 06:16:01 ~3 min android 📦tgz
✔️ c9ab003 #4 2023-11-09 06:16:46 ~3 min ios 📦tgz
✔️ 52a43f1 #5 2023-11-13 08:44:06 ~2 min nix-flake 📄log
✔️ 52a43f1 #8 2023-11-13 08:45:16 ~3 min linux 📦deb
✔️ 52a43f1 #5 2023-11-13 08:46:15 ~4 min android 📦tgz
✔️ 52a43f1 #5 2023-11-13 08:46:47 ~4 min ios 📦tgz
✔️ 52a43f1 #5 2023-11-13 08:48:21 ~6 min tests 📄log
✔️ 52a43f1 #5 2023-11-13 08:48:41 ~6 min tests 📄log

@harsh-98 harsh-98 force-pushed the LibraryDnsDiscovery branch from 7b6c438 to 9ad1721 Compare November 9, 2023 06:06
@harsh-98 harsh-98 force-pushed the LibraryDnsDiscovery branch from 9ad1721 to c9ab003 Compare November 9, 2023 06:12
@harsh-98 harsh-98 marked this pull request as ready for review November 9, 2023 07:17
chaitanyaprem
chaitanyaprem approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

library/config.go Show resolved Hide resolved
@harsh-98 harsh-98 merged commit 73bcb2e into master Nov 13, 2023
@harsh-98 harsh-98 deleted the LibraryDnsDiscovery branch November 13, 2023 12:17
@chaitanyaprem chaitanyaprem mentioned this pull request Nov 14, 2023
Merged
1 task
@richard-ramos richard-ramos mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees

@harsh-98 harsh-98

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsh-98 @status-im-auto @chaitanyaprem