Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waku relay API: auto-subscribe #17

Closed
D4nte opened this issue Mar 29, 2021 · 3 comments
Closed

waku relay API: auto-subscribe #17

D4nte opened this issue Mar 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@D4nte
Copy link
Contributor

D4nte commented Mar 29, 2021

Problem

Currently, developer always need to do a call to WakuRelay.subscribe() to use waku relay.

Solution

Similarly to nim-waku, an auto-subscribe to the default topic can make the API easier to use as the developer would have one less call to do.

@D4nte D4nte added API enhancement New feature or request labels Apr 1, 2021
@D4nte
Copy link
Contributor Author

D4nte commented Apr 1, 2021

Let's wait until waku-org/nwaku#445 is resolved before trying to tackle this one as we know of some timing issues and there would be little value if we have various sleep in the library to allow for a resilient auto-subscribe.

@oskarth
Copy link

oskarth commented Apr 1, 2021

This is an issue more for library design, is that correct? In terms of making it ergonomic and having to setup fewer things for the default behavior.

@D4nte
Copy link
Contributor Author

D4nte commented Apr 1, 2021

yes correct, I use the label 'API' to flag anything which is more about the API itself, the dev ex using it and any issue/improvements that can be done on its current design.

This is low priority as the focus is to get the chat app to support waku store first.

D4nte added a commit that referenced this issue Apr 15, 2021
At this stage, if waku relay is mounted then we always want to subscribe
to default topic.

We can re-introduce the flexibility once we know what matters to the user.

Resolves #17.
D4nte added a commit that referenced this issue Apr 15, 2021
At this stage, if waku relay is mounted then we always want to subscribe
to default topic.

We can re-introduce the flexibility once we know what matters to the user.

Resolves #17.
@bors bors bot closed this as completed in 8964623 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants